Hi,
On Wed, Aug 23, 2023 at 10:54:29AM +0200, Grant B Adams wrote:
> Enabling the tps65217-charger driver/module causes an interrupt conflict
> with the vbus driver resulting in a probe failure.
> The conflict is resolved by changing both driver's threaded interrupt
> request function from IRQF_ONESHOT to IRQF_SHARED.
>
> Signed-off-by: Grant B Adams <nemith592@xxxxxxxxx>
> ---
Your commit message does not explain why IRQF_ONESHOT is dropped;
IRQF_ONESHOT and IRQF_SHARED are not mutually exclusive.
-- Sebastian
> drivers/power/supply/tps65217_charger.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/supply/tps65217_charger.c b/drivers/power/supply/tps65217_charger.c
> index a4bc9f2a10bc..6f68becdbfd0 100644
> --- a/drivers/power/supply/tps65217_charger.c
> +++ b/drivers/power/supply/tps65217_charger.c
> @@ -238,7 +238,7 @@ static int tps65217_charger_probe(struct platform_device *pdev)
> for (i = 0; i < NUM_CHARGER_IRQS; i++) {
> ret = devm_request_threaded_irq(&pdev->dev, irq[i], NULL,
> tps65217_charger_irq,
> - IRQF_ONESHOT, "tps65217-charger",
> + IRQF_SHARED, "tps65217-charger",
> charger);
> if (ret) {
> dev_err(charger->dev,
> --
> 2.34.1
>
Attachment:
signature.asc
Description: PGP signature
