Re: [PATCH 2/8] usb: gadget: add anonymous definition in some struct for trace purpose

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 9/14/2023 10:54 PM, Alan Stern wrote:
You didn't include the version number in the Subject: line.  Undoubtedly
Greg's automatic error checker will warn you about this.  Unless the
version number is clearly marked for each patch, it's difficult for his
programs to tell which email message contains the most recent version.

On Thu, Sep 14, 2023 at 06:02:56PM +0800, Linyu Yuan wrote:
Some UDC trace event will save usb udc information, but it use one int
size buffer to save one bit information of usb udc, it is wast trace
buffer.

Add anonymous union which have one u32 member can be used by trace event
during fast assign stage to save more entries with same trace ring buffer
size.

Signed-off-by: Linyu Yuan <quic_linyyuan@xxxxxxxxxxx>
---
And you didn't include the version change information here, below the
"---" line.

Apart from that, this is a _lot_ better than before!  I don't know if
Greg will think this change is worth merging, but at least now it's
possible to read the code and understand what's going on.


according Steven's comment, maybe will always save data in little endian at trace event

fast assign stage.

it will add definition of bit field back.



Alan Stern




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux