> From: Hans de Goede > > Hi, > > On 9/13/23 08:12, kernel test robot wrote: > > Hi Wentong, > > > > kernel test robot noticed the following build warnings: > > > > [auto build test WARNING on wsa/i2c/for-next] [also build test WARNING > > on broonie-spi/for-next linus/master v6.6-rc1 next-20230912] [cannot > > apply to usb/usb-testing usb/usb-next usb/usb-linus] [If your patch is > > applied to the wrong git tree, kindly drop us a note. > > And when submitting patch, we suggest to use '--base' as documented in > > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > > > url: https://github.com/intel-lab-lkp/linux/commits/Wentong-Wu/usb-Add- > support-for-Intel-LJCA-device/20230913-094239 > > base: https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/for- > next > > patch link: https://lore.kernel.org/r/1694569212-10080-2-git-send-email- > wentong.wu%40intel.com > > patch subject: [PATCH v16 1/4] usb: Add support for Intel LJCA device > > config: sparc-allyesconfig > > (https://download.01.org/0day- > ci/archive/20230913/202309131427.AUBwVNB > > m-lkp@xxxxxxxxx/config) > > compiler: sparc64-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 > > build): > > (https://download.01.org/0day- > ci/archive/20230913/202309131427.AUBwVNB > > m-lkp@xxxxxxxxx/reproduce) > > > > If you fix the issue in a separate patch/commit (i.e. not just a new > > version of the same patch/commit), kindly add following tags > > | Reported-by: kernel test robot <lkp@xxxxxxxxx> > > | Closes: > > | https://lore.kernel.org/oe-kbuild-all/202309131427.AUBwVNBm-lkp@inte > > | l.com/ > > > > All warnings (new ones prefixed by >>): > > > > drivers/usb/misc/usb-ljca.c: In function 'ljca_match_device_ids': > > drivers/usb/misc/usb-ljca.c:389:27: error: implicit declaration of function > 'acpi_device_uid'; did you mean 'dmi_device_id'? [-Werror=implicit-function- > declaration] > > 389 | const char *uid = acpi_device_uid(adev); > > | ^~~~~~~~~~~~~~~ > > | dmi_device_id > >>> drivers/usb/misc/usb-ljca.c:389:27: warning: initialization of > >>> 'const char *' from 'int' makes pointer from integer without a cast > >>> [-Wint-conversion] > > drivers/usb/misc/usb-ljca.c:391:13: error: implicit declaration of function > 'acpi_match_device_ids'; did you mean 'ljca_match_device_ids'? [- > Werror=implicit-function-declaration] > > 391 | if (acpi_match_device_ids(adev, wd->ids)) > > | ^~~~~~~~~~~~~~~~~~~~~ > > | ljca_match_device_ids > > drivers/usb/misc/usb-ljca.c: In function 'ljca_auxdev_acpi_bind': > > drivers/usb/misc/usb-ljca.c:429:16: error: implicit declaration of function > 'acpi_find_child_device'; did you mean 'acpi_match_device'? [-Werror=implicit- > function-declaration] > > 429 | adev = acpi_find_child_device(parent, adr, false); > > | ^~~~~~~~~~~~~~~~~~~~~~ > > | acpi_match_device > >>> drivers/usb/misc/usb-ljca.c:429:14: warning: assignment to 'struct > >>> acpi_device *' from 'int' makes pointer from integer without a cast > >>> [-Wint-conversion] > > 429 | adev = acpi_find_child_device(parent, adr, false); > > | ^ > > drivers/usb/misc/usb-ljca.c:458:9: error: implicit declaration of function > 'acpi_dev_for_each_child'; did you mean 'device_for_each_child'? [- > Werror=implicit-function-declaration] > > 458 | acpi_dev_for_each_child(parent, ljca_match_device_ids, &wd); > > | ^~~~~~~~~~~~~~~~~~~~~~~ > > | device_for_each_child > > cc1: some warnings being treated as errors > > Ok, so this need to have a "depends on ACPI" added to its Kconfig entry. There > are other ways to fix it, but this driver will not be functional without ACPI > anyways so "depends on ACPI" seems to be the best solution for this. Yes, "depends on ACPI" is already there, but I have to remove "depends on COMPILE_TEST" Thanks Wentong > > Regards, > > Hans
