Re: [PATCH v2 00/11] usb: gadget: reduce usb gadget trace event buffer usage

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 11, 2023 at 07:24:35PM +0800, Linyu Yuan wrote:
> some trace event use an interger to to save a bit field info of gadget,
> also some trace save endpoint name in string forat, it all can be
> chagned to other way at trace event store phase.
> 
> bit field can be replace with a union interger member which include
> multiple bit fields.
> 
> ep name stringe can be replace to a interger which contaion number
> and dir info.

Ok, but how much memory did you actually save here?  Is the memory saved
only if tracing is enbaled, or it is always?  Is there a speed penality
for these changes or is it the same?

You are doing a lot of code reorginization without any real explaination
of why this is needed, nor proof about it.

thanks,

greg k-h



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux