Hi Heikki, Thank you for the review. > -----Original Message----- > From: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx> > Sent: Monday, September 4, 2023 12:12 AM > To: Patel, Utkarsh H <utkarsh.h.patel@xxxxxxxxx> > Cc: linux-kernel@xxxxxxxxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx; > pmalani@xxxxxxxxxxxx; chrome-platform@xxxxxxxxxxxxxxx; > andriy.shevchenko@xxxxxxxxxxxxxxx; bleung@xxxxxxxxxxxx > Subject: Re: [PATCH v2 3/5] usb: pd: Add helper macro to get Type C cable > speed > > On Mon, Sep 04, 2023 at 10:08:42AM +0300, Heikki Krogerus wrote: > > On Wed, Aug 30, 2023 at 03:39:48PM -0700, Utkarsh Patel wrote: > > > Added a helper macro to get the Type C cable speed when provided the > > > cable VDO. > > > > > > Signed-off-by: Utkarsh Patel <utkarsh.h.patel@xxxxxxxxx> > > > > Reviewed-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx> > > > > > --- > > > Changes in v2: > > > - This change is being added as new patch in this series. > > > > > > include/linux/usb/pd_vdo.h | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/include/linux/usb/pd_vdo.h b/include/linux/usb/pd_vdo.h > > > index b057250704e8..3a747938cdab 100644 > > > --- a/include/linux/usb/pd_vdo.h > > > +++ b/include/linux/usb/pd_vdo.h > > > @@ -376,6 +376,7 @@ > > > | ((vbm) & 0x3) << 9 | (sbu) << 8 | (sbut) << 7 | ((cur) & 0x3) << 5 > \ > > > | (vbt) << 4 | (sopp) << 3 | ((spd) & 0x7)) > > > > > > +#define VDO_TYPEC_CABLE_SPEED(vdo) ((vdo) & 0x7) > > > #define VDO_TYPEC_CABLE_TYPE(vdo) (((vdo) >> 18) & 0x3) > > Hold on! You are not using this anywhere in the patch set? > > Since this is just a helper, I think it would be appropriate to introduce it > together with a user for it. > Ack. Sincerely, Utkarsh Patel.
