Hi Wentong, On Fri, Sep 01, 2023 at 01:36:17PM +0800, Wentong Wu wrote: > This driver communicate with LJCA GPIO module with specific > protocol through interfaces exported by LJCA USB driver. > Update the driver according to LJCA USB driver's changes. > > Signed-off-by: Wentong Wu <wentong.wu@xxxxxxxxx> > Reviewed-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> > Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx> > Acked-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx> I am not understanding this patch... Looks like a collection of random to relevant changes you did in gpio-ljca.c. I'm not able to review this, can you please split it in minor changes? Meanwhile the previous patches should be able to work without this one, right? Andi