On Tue, 29 Aug 2023 at 20:09, Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > > On 29/08/2023 16:35, Rob Herring wrote: > > > > On Tue, 29 Aug 2023 19:28:13 +0530, Praveenkumar I wrote: > >> Add ipq5332 USB3 SS UNIPHY support. > >> > >> Signed-off-by: Praveenkumar I <quic_ipkumar@xxxxxxxxxxx> > >> --- > >> .../devicetree/bindings/phy/qcom,uniphy.yaml | 117 +++++++++++++++++- > >> 1 file changed, 114 insertions(+), 3 deletions(-) > >> > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > > > yamllint warnings/errors: > > > > dtschema/dtc warnings/errors: > > In file included from Documentation/devicetree/bindings/phy/qcom,uniphy.example.dts:45: > > ./scripts/dtc/include-prefixes/dt-bindings/clock/qcom,ipq5332-gcc.h:19: warning: "GCC_BLSP1_AHB_CLK" redefined > > 19 | #define GCC_BLSP1_AHB_CLK 10 > > | > > So the only patch which actually needed dependency information did not > have it. All other patches have something, even defconfig (!). Confusing. Much simpler. This patch adds a second example to the schema. Both examples include something-gcc.h. As both examples end up in the same example.dts file, second include conflicts with the first one. -- With best wishes Dmitry
