Re: [PATCH v2] usb: typec: qcom: check regulator enable status before disabling it

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 25/08/2023 11:03, hui liu wrote:
Hi Heikki,

I will let Bryan to comment, I am using the driver to support the pdphy in SMB2352 and there is no external regulator required, so I am just using a dummy regulator device and I saw this unbalanced regulator disabling warnings, so my intention for this change is just fixing the warning message. However, I am fine with whatever suggestion you have, since the logic is straightforward, and I can make the changes once you have the agreement.

Thanks,
Hui

Err well on real hardware with a real regulator I don't see this error.

I'd say we should try the second proposed changed in pdphy_start pdphy_stop since it looks neater.

If it works then fine, else lets stick to your original fix.

---
bod



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux