On Sun, Aug 20, 2023 at 11:15:18PM +0800, Xu Yang wrote: > The try_src_count and try_snk_count may still be 1 after enter into > unattached state. This may be caused by below case: > - SNK_TRY->SNK_TRY_WAIT->SRC_TRYWAIT->SNK_UNATTACHED > - SRC_TRY->SRC_TRY_WAIT->SNK_TRYWAIT->SNK_UNATTACHED > > The port->attached is not true at the end and tcpm_reset_port() will not > be called. This will reset counter into for these cases, otherwise the tcpm > won't try role when new cable attached. > > Signed-off-by: Xu Yang <xu.yang_2@xxxxxxx> Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx> > --- > drivers/usb/typec/tcpm/tcpm.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c > index 5639b9a1e0bf..c9a186a8c58c 100644 > --- a/drivers/usb/typec/tcpm/tcpm.c > +++ b/drivers/usb/typec/tcpm/tcpm.c > @@ -3719,6 +3719,9 @@ static void tcpm_detach(struct tcpm_port *port) > if (tcpm_port_is_disconnected(port)) > port->hard_reset_count = 0; > > + port->try_src_count = 0; > + port->try_snk_count = 0; > + > if (!port->attached) > return; > > -- > 2.34.1 >
