On Sun, Aug 20, 2023 at 07:44:01PM +0100, Biju Das wrote: > The RT1715 needs 0.35V/0.75V rx threshold for rd/rp whereas it is 0.4V/0.7V > for RT1711H. Add rxdz_sel variable to struct rt1711h_chip_info for > handling this difference. ... > struct rt1711h_chip_info { > u16 did; > + u32 rxdz_sel; > }; Again, run pahole. And see the difference, if any, depending on the place of a new member. Note, some 64-bit architectures may require 8-byte alignment even for 4-byte members. ... > static const struct rt1711h_chip_info rt1711h = { > .did = RT1711H_DID, > + .rxdz_sel = 0, > }; Unneeded change. -- With Best Regards, Andy Shevchenko