On Tue, Aug 08, 2023 at 01:33:45AM -0400, Da Xue wrote: > On Tue, Aug 8, 2023 at 12:56 AM Greg Kroah-Hartman > <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > > > On Tue, Aug 08, 2023 at 03:25:10AM +0000, Luke Lu wrote: > > > Device connected to usb otg port of GXL-based boards can not be > > > recognised after resumption, doesn't recover even if disconnect and > > > reconnect the device. dmesg shows it disconnects during resumption. > > > > > > [ 41.492911] usb 1-2: USB disconnect, device number 3 > > > [ 41.499346] usb 1-2: unregistering device > > > [ 41.511939] usb 1-2: unregistering interface 1-2:1.0 > > > > > > Calling usb_post_init() will fix this issue, and it's tested and > > > verified on libretech's aml-s905x-cc board. > > > > > > Signed-off-by: Luke Lu <luke.lu@libre.computer> > > > > What commit id does this fix? Should it also go to stable kernels? > > Hi Greg, > > Suspend device tree flag has not been enabled in-tree for the Amlogic > GXL (S805X/S905X/S905D) series due it having PSCI 0.2 and thus never > untested. Most of the suspend resume code was only tested on newer > G12A/B series. > > This and "[PATCH v3] net: phy: meson-gxl: implement > meson_gxl_phy_resume()" fixes USB and Ethernet after resume. HDMI > requires another fix. > > It would be great if they could go into stable since we are carrying > these two patches in our tree on 6.1 and they're applicable back to > 5.4 but I am not sure what the criteria is. https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html has the criteria. If you think it should go there, then please resend with a cc: stable tag in the signed-off-by area. thanks, greg k-h
