HI Greg: On Tue, Aug 8, 2023 at 4:56 AM Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > On Tue, Aug 08, 2023 at 03:25:10AM +0000, Luke Lu wrote: > > Device connected to usb otg port of GXL-based boards can not be > > recognised after resumption, doesn't recover even if disconnect and > > reconnect the device. dmesg shows it disconnects during resumption. > > > > [ 41.492911] usb 1-2: USB disconnect, device number 3 > > [ 41.499346] usb 1-2: unregistering device > > [ 41.511939] usb 1-2: unregistering interface 1-2:1.0 > > > > Calling usb_post_init() will fix this issue, and it's tested and > > verified on libretech's aml-s905x-cc board. > > > > Signed-off-by: Luke Lu <luke.lu@libre.computer> > > What commit id does this fix? Using "git blame" to explore the history, found dwc3_meson_g12a_resume() was introduced along with the file of drivers/usb/dwc3/dwc3-meson-g12a.c. as Da Xue pointed out, the suspend/resume was never tested in GXL based SoC, so it's broken since the beginning.. For the Fixes tag, I think it's proper to use "5b0ba0caaf3a: (usb: dwc3: meson-g12a: refactor usb init)" since the usb_post_init() function was introduced in this commit and this patch will depend on it. > Should it also go to stable kernels? > Yes, It would be great if the patch can go to stable tree, thanks for suggesting this I have it tested on 6.1-lts tree. Btw, I would wait for a few days for more comments and CC to stable in next v2 if no objection. > thanks, > > greg k-h Luke
