On Mon, Jul 31, 2023, Ladislav Michl wrote: > From: Ladislav Michl <ladis@xxxxxxxxxxxxxx> > > Power gpio configuration is done from the middle of > dwc3_octeon_clocks_start leaving hardware in half-initialized > state if it fails. As that indicates dwc3_octeon_clocks_start > does more than just initialize the clocks rename it appropriately > and verify power gpio configuration in advance at the beginning > of device probe. > > Signed-off-by: Ladislav Michl <ladis@xxxxxxxxxxxxxx> > --- > CHANGES: > - v4: new patch > - v5: use uintptr_t instead of u64 to retype base address to make 32bit > compilers happy. > > drivers/usb/dwc3/dwc3-octeon.c | 90 ++++++++++++++++------------------ > 1 file changed, 43 insertions(+), 47 deletions(-) > > diff --git a/drivers/usb/dwc3/dwc3-octeon.c b/drivers/usb/dwc3/dwc3-octeon.c > index 24e75881b5cf..0dc45dda134c 100644 > --- a/drivers/usb/dwc3/dwc3-octeon.c > +++ b/drivers/usb/dwc3/dwc3-octeon.c > @@ -192,6 +192,8 @@ struct dwc3_octeon { > void __iomem *base; > }; > Acked-by: Thinh Nguyen <Thinh.Nguyen@xxxxxxxxxxxx> Thanks, Thinh