On Tue, Aug 01, 2023 at 03:27:04PM +0800, chengdong zhou wrote: > Thank you for your patient response. > > On Tue, Aug 1, 2023 at 2:23 PM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > > > > > Please document this in the changelog text. > > But I can't find the changelog text anywhere. That is what you are writing here for the commit. Please read the kernel documentation for how to submit a patch, it will explain this. > > But you changed the name: > > > > > > > - ss->function.name = "source/sink"; > > > > > + ss->function.name = "sourcesink"; > > > > isn't that visable to userspace? > > Yes, I removed the "/". Because the macro definition > DECLARE_USB_FUNCTION_INIT does not support "/". > Should I stick with the original "SourceSink"? I think using the > Linux-style "sourcesink" is better. By the way, due to the current > bug, no one should be able to use "source/sink" in userspace. But doesn't the '/' mean that you have a subdirectory here? What did userspace look like before this, and what does it look like now? thanks, greg k-h
