On Tue, Aug 01, 2023, Thinh Nguyen wrote: > On Mon, Jul 31, 2023, Ladislav Michl wrote: > > From: Ladislav Michl <ladis@xxxxxxxxxxxxxx> > > > > Pass dwc3_octeon instead of just the base. It fits with the > > function names and it requires less change in the future if > > access to dwc3_octeon is needed. > > > > Signed-off-by: Ladislav Michl <ladis@xxxxxxxxxxxxxx> > > Reviewed-by: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx> > > --- > > CHANGES: > > - v4: new patch > > - v5: Philippe's review tag > > > > drivers/usb/dwc3/dwc3-octeon.c | 23 ++++++++++++----------- > > 1 file changed, 12 insertions(+), 11 deletions(-) > > > > diff --git a/drivers/usb/dwc3/dwc3-octeon.c b/drivers/usb/dwc3/dwc3-octeon.c > > index 69fe50cfa719..24e75881b5cf 100644 > > --- a/drivers/usb/dwc3/dwc3-octeon.c > > +++ b/drivers/usb/dwc3/dwc3-octeon.c > > @@ -300,12 +300,13 @@ static int dwc3_octeon_config_power(struct device *dev, void __iomem *base) > > May as well do it for dwc3_octeon_config_power() too? > Nevermind this. I just notice you rewrote this function later. Ignore this comment. Acked-by: Thinh Nguyen <Thinh.Nguyen@xxxxxxxxxxxx> Thanks, Thinh