On 7/31/23 06:12, Heikki Krogerus wrote: > This fixes an undefined reference to `usb_debug_root' issue > when USB_COMMON is not enabled. > > Fixes: 0a453dc9f260 ("usb: typec: intel_pmc_mux: Expose IOM port status to debugfs") > Reported-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> > Closes: https://lore.kernel.org/lkml/c3bb8781-676d-2448-cfbb-62e29f1f570b@xxxxxxxxxxxxx/ > Cc: Rajat Khandelwal <rajat.khandelwal@xxxxxxxxxxxxxxx> > Signed-off-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx> Tested-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> # build-tested Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> Thanks. > --- > drivers/usb/typec/mux/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/typec/mux/Kconfig b/drivers/usb/typec/mux/Kconfig > index 784b9d8107e9b..65da61150ba78 100644 > --- a/drivers/usb/typec/mux/Kconfig > +++ b/drivers/usb/typec/mux/Kconfig > @@ -29,6 +29,7 @@ config TYPEC_MUX_INTEL_PMC > tristate "Intel PMC mux control" > depends on ACPI > depends on INTEL_SCU_IPC > + select USB_COMMON > select USB_ROLE_SWITCH > help > Driver for USB muxes controlled by Intel PMC FW. Intel PMC FW can -- ~Randy