On 28/07/2023 19:37, Stanley Chang[昌育德] wrote: >>> + >>> + realtek,disable-usb3-phy: >>> + description: Close USB 3.0 PHY if the board design not support USB 3.0. >>> + type: boolean >>> + >>> + realtek,enable-l4icg: >>> + description: Enable the power saving feature l4icg by hardware clock. >>> + gating. >> >> You described the desired Linux feature or behavior, not the actual hardware. >> The bindings are about the latter, so instead you need to rephrase the property >> and its description to match actual hardware >> capabilities/features/configuration etc. > > The l4icg entry is a hardware feature for power saving. > The term may not clearly convey the function. > So instead of the term "l4icg" I use "hw clock gating". > > realtek,enable-hw-clock-gating: > description: Enable the clock gated function which will gating sram > clock when dbus idle. And why this should be configurable per board? It looks you like to put OS policy into DT, so no. Best regards, Krzysztof
