Re: [PATCH] Quectel EM05G LTE Modem with new Product ID

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Marin,

When working upstream you should remember to reply inline (and trim
unneeded context) rather than top posting as you did here.

Also wrap your mails at 72 columns or so (I've added the missing
newlines below).

On Mon, Jul 24, 2023 at 09:24:34AM +0000, Martin Kohn wrote:

> Could you please point me to what I did exactly wrong, now I tried
> second time and as I'm new here, I honestly do not know what I did
> wrong?

It looks your second attempt worked correctly:

	https://lore.kernel.org/all/AM0PR04MB576480684AA0896B32D32975973FA@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/#t

In your previous attempt, tabs had specifically been replaced by spaces.

> I did run checkpatch and applied it back to my repository and
> everything is fine on my side.

As long as you ran checkpatch on the patch (and applied it) *after*
mailing it to yourself, you should be good.

Also remember to include me as a recipient when posting. My filters
should catch it anyway, but it may take some time before I see it.

Johan



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux