On 24/07/2023 08:35, Ng, Adrian Ho Yin wrote: >>> diff --git >>> a/Documentation/devicetree/bindings/usb/intel,socfpga-dwc3.yaml >>> b/Documentation/devicetree/bindings/usb/intel,socfpga-dwc3.yaml >>> new file mode 100644 >>> index 000000000000..dedef70df887 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/usb/intel,socfpga-dwc3.yaml >>> @@ -0,0 +1,78 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/usb/intel,socfpga-dwc3.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Intel SoCFPGA DWC3 USB controller >>> + >>> +maintainers: >>> + - Adrian Ng Ho Yin <adrian.ho.yin.ng@xxxxxxxxx> >>> + >>> +properties: >>> + compatible: >>> + const: intel,agilex5-dwc3 >> >> Why using compatible style different than other Agilex blocks? Which >> one is recommended/official/correct? > > This style is used so that future SoCFPGA products can reuse the same binding. Wait, why? How future products are relevant to style of compatible for existing device? Again - why using different style? Which one is correct? Best regards, Krzysztof