Hi Krishna, Please remember to trim unnecessary context from your replies (e.g. as it makes it easier to read your reply and later the entire thread in the mailing list archives). On Mon, Jul 03, 2023 at 12:18:14AM +0530, Krishna Kurapati PSSNV wrote: > On 6/27/2023 5:15 PM, Johan Hovold wrote: > > On Wed, Jun 21, 2023 at 10:06:21AM +0530, Krishna Kurapati wrote: > >> diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h > >> index 8b1295e4dcdd..42fb17aa66fa 100644 > >> --- a/drivers/usb/dwc3/core.h > >> +++ b/drivers/usb/dwc3/core.h > >> @@ -33,6 +33,10 @@ > >> > >> #include <linux/power_supply.h> > >> > >> +#define XHCI_EXT_PORT_MAJOR(x) (((x) >> 24) & 0xff) > >> +#define XHCI_EXT_PORT_MINOR(x) (((x) >> 16) & 0xff) > >> +#define XHCI_EXT_PORT_COUNT(x) (((x) >> 8) & 0xff) > > > > Again, don't copy defines from xhci. > > > > Looks like these should be moved to the xhci-ext-caps.h header along > > with struct xhci_protocol_caps. > > > Can't we just give them an exception ? Modifying xhci stuff doesn't > sound good. Can I just rename them and keep them here ? Nope. This is mainline, not Qualcomm's vendor kernel. Johan
