Re: [PATCH] Quectel EM05G LTE Modem with new Product ID

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jul 20, 2023 at 12:30:53PM +0000, Martin Kohn wrote:
> Hello everyone,
> 
> Quectel has changed the product ID for EM05G LTE Modem (global variant), here my verified patch for it:
> 
> >From 7a19d929aa07b3541f6a1205cb0ce3f0f5dc54a6 Mon Sep 17 00:00:00 2001
> From: Martin Kohn mailto:m.kohn@xxxxxxxxxxx
> Date: Wed, 19 Jul 2023 12:04:21 +0200
> Subject: [PATCH] Quectel has changed the Product ID from 030a to 030e for the
> EM05G modem. Both versions must be supported in the future.
> 
> Signed-off-by: Martin Kohn mailto:m.kohn@xxxxxxxxxxx
> ---
> drivers/usb/serial/option.c | 3 +++
> 1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> index 288a96a74266..64b1995b410d 100644
> --- a/drivers/usb/serial/option.c
> +++ b/drivers/usb/serial/option.c
> @@ -256,6 +256,7 @@ static void option_instat_callback(struct urb *urb);
> #define QUECTEL_PRODUCT_BG96                                         0x0296
> #define QUECTEL_PRODUCT_EP06                                         0x0306
> #define QUECTEL_PRODUCT_EM05G                                    0x030a
> +#define QUECTEL_PRODUCT_EM05GV2                              0x030e
> #define QUECTEL_PRODUCT_EM060K                                   0x030b
> #define QUECTEL_PRODUCT_EM05G_CS                             0x030c
> #define QUECTEL_PRODUCT_EM05CN_SG                          0x0310
> @@ -1186,6 +1187,8 @@ static const struct usb_device_id option_ids[] = {
>                  .driver_info = RSVD(6) | ZLP },
>                { USB_DEVICE_INTERFACE_CLASS(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_EM05G, 0xff),
>                  .driver_info = RSVD(6) | ZLP },
> +        { USB_DEVICE_INTERFACE_CLASS(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_EM05GV2, 0xff),
> +          .driver_info = RSVD(6) | ZLP },
>                { USB_DEVICE_INTERFACE_CLASS(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_EM05G_CS, 0xff),
>                  .driver_info = RSVD(6) | ZLP },
>                { USB_DEVICE_INTERFACE_CLASS(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_EM05G_GR, 0xff),
> -- 
> 2.25.1
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch is malformed (tabs converted to spaces, linewrapped, etc.)
  and can not be applied.  Please read the file,
  Documentation/process/email-clients.rst in order to fix this.

- Your patch was attached, please place it inline so that it can be
  applied directly from the email message itself.

- You did not specify a description of why the patch is needed, or
  possibly, any description at all, in the email body.  Please read the
  section entitled "The canonical patch format" in the kernel file,
  Documentation/process/submitting-patches.rst for what is needed in
  order to properly describe the change.

- You did not write a descriptive Subject: for the patch, allowing Greg,
  and everyone else, to know what this patch is all about.  Please read
  the section entitled "The canonical patch format" in the kernel file,
  Documentation/process/submitting-patches.rst for what a proper
  Subject: line should look like.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux