[PATCH] USB: serial: simple-serial: spell out the ordering

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



keeping a list ordered alphabetically instead
nummerically be vendor/product ID is unusual.
This is so odd that examples do not help.
It needs to be clearly stated with strong words.

Signed-off-by: Oliver Neukum <oneukum@xxxxxxxx>
---
 drivers/usb/serial/usb-serial-simple.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/drivers/usb/serial/usb-serial-simple.c b/drivers/usb/serial/usb-serial-simple.c
index 24b8772a345e..954b3be7403d 100644
--- a/drivers/usb/serial/usb-serial-simple.c
+++ b/drivers/usb/serial/usb-serial-simple.c
@@ -33,6 +33,16 @@ static struct usb_serial_driver vendor##_device = {		\
 
 #define DEVICE(vendor, IDS)	DEVICE_N(vendor, IDS, 1)
 
+/*
+ * These tables are NOT in order of device id by intention
+ *
+ * Keep them and add new entries sorted by
+ *
+ * 1. Alphabetical order of the vendor name
+ * 2. Alphabetical order of the product name
+ *
+ */
+
 /* Medtronic CareLink USB driver */
 #define CARELINK_IDS()			\
 	{ USB_DEVICE(0x0a21, 0x8001) }	/* MMT-7305WW */
-- 
2.41.0




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux