Hi Greg, Thank you for the review and feedback. > -----Original Message----- > From: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> > Sent: Tuesday, July 18, 2023 6:29 AM > To: Patel, Utkarsh H <utkarsh.h.patel@xxxxxxxxx> > Cc: linux-kernel@xxxxxxxxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx; > heikki.krogerus@xxxxxxxxxxxxxxx; pmalani@xxxxxxxxxxxx; > bleung@xxxxxxxxxxxx > Subject: Re: [PATCH v4 2/2] usb: typec: intel_pmc_mux: Configure Active and > Retimer Cable type > > On Mon, Jul 17, 2023 at 07:47:03PM -0700, Utkarsh Patel wrote: > > Cable type such as active and retimer received as a part of > > Thunderbolt3 or Thunderbolt4 cable discover mode VDO needs to be > > configured in the thunderbolt alternate mode. > > > > Configuring the register bits for this cable type is changed with > > Intel Meteor Lake platform. BIT2 for Retimer/Redriver cable and BIT22 > > for Active/Passive cable. > > > > Reviewed-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx> > > Signed-off-by: Utkarsh Patel <utkarsh.h.patel@xxxxxxxxx> > > --- > > Changes in v4: > > - No changes. > > > > Changes in v3: > > - No changes. > > > > Changes in v2: > > - No changes. > > --- > > --- > > drivers/usb/typec/mux/intel_pmc_mux.c | 28 > > +++++++++++++++++++++++---- > > 1 file changed, 24 insertions(+), 4 deletions(-) > > Why the 2 --- lines? This is by mistake. > > And why are you not cc:ing all the proper people (i.e. the person that can > actually apply this...)? > Ack. I will correct both of these when I send next patch. Sincerely, Utkarsh Patel.
