On Tue, Jul 18, 2023 at 10:16:55AM +1000, Ross Maynard wrote: > Hi Greg, > > This is related to Oliver Neukum's patch > 6605cc67ca18b9d583eb96e18a20f5f4e726103c (USB: zaurus: support another > broken Zaurus) which you committed in 2022 to fix broken support for the > Zaurus SL-6000. > > Prior to that I had been able to track down the original offending patch > using git bisect as you had suggested to me: > 16adf5d07987d93675945f3cecf0e33706566005 (usbnet: Remove over-broad module > alias from zaurus). > > It turns out that the offending patch also broke support for 3 other Zaurus > models: A300, C700 and B500/SL-5600. My patch adds the 3 device IDs to the > driver in the same way Oliver added the SL-6000 ID in his patch. > > Could you please review the attached patch? I tested it on all 3 devices and > it fixed the problem. For your reference, the associated bug URL is > https://bugzilla.kernel.org/show_bug.cgi?id=217632. I'll be glad to accept it if you resend it in a format that I can apply it in. I'll run my patch-bot on it to give you some hints on what needs to be done here. thanks, greg k-h