Hi Rob, On Fri, 14 Jul 2023 11:50:23 -0600 Rob Herring <robh@xxxxxxxxxx> wrote: > The DT of_device.h and of_platform.h date back to the separate > of_platform_bus_type before it as merged into the regular platform bus. > As part of that merge prepping Arm DT support 13 years ago, they > "temporarily" include each other. They also include platform_device.h > and of.h. As a result, there's a pretty much random mix of those include > files used throughout the tree. In order to detangle these headers and > replace the implicit includes with struct declarations, users need to > explicitly include the correct includes. > > Signed-off-by: Rob Herring <robh@xxxxxxxxxx> > --- [...] > diff --git a/drivers/usb/gadget/udc/renesas_usbf.c b/drivers/usb/gadget/udc/renesas_usbf.c > index 6cd0af83e91e..3482b41d0646 100644 > --- a/drivers/usb/gadget/udc/renesas_usbf.c > +++ b/drivers/usb/gadget/udc/renesas_usbf.c > @@ -12,10 +12,9 @@ > #include <linux/iopoll.h> > #include <linux/kernel.h> > #include <linux/kfifo.h> > +#include <linux/mod_devicetable.h> > #include <linux/module.h> > -#include <linux/of_address.h> > -#include <linux/of_irq.h> > -#include <linux/of_platform.h> > +#include <linux/platform_device.h> > #include <linux/pm_runtime.h> > #include <linux/types.h> > #include <linux/usb/composite.h> Acked-by: Herve Codina <herve.codina@xxxxxxxxxxx> Best regards, Hervé