Re: [PATCH] Style error/warning fixes: replacing space with tabs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 09/07/2023 02:51, Prince Kumar Maurya wrote:
> Style fixes for warning found using checkpatch.pl script 
> 
> Signed-off-by: Prince Kumar Maurya <princekumarmaurya06@xxxxxxxxx>
> ---
>  drivers/usb/core/hub.c | 58 +++++++++++++++++++++---------------------
>  1 file changed, 29 insertions(+), 29 deletions(-)
> 
> diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
> index a739403a9e45..82a7b127a340 100644
> --- a/drivers/usb/core/hub.c
> +++ b/drivers/usb/core/hub.c
> @@ -1777,7 +1777,7 @@ static bool hub_descriptor_is_sane(struct usb_host_interface *desc)
>  	if (!usb_endpoint_is_int_in(&desc->endpoint[0].desc))
>  		return false;
>  
> -        return true;
> +		return true;

This does not look like correctly indented.

>  }
>  
>  static int hub_probe(struct usb_interface *intf, const struct usb_device_id *id)
> @@ -5854,37 +5854,37 @@ static void hub_event(struct work_struct *work)
>  }
>  
>  static const struct usb_device_id hub_id_table[] = {
> -    { .match_flags = USB_DEVICE_ID_MATCH_VENDOR
> -                   | USB_DEVICE_ID_MATCH_PRODUCT
> -                   | USB_DEVICE_ID_MATCH_INT_CLASS,
> -      .idVendor = USB_VENDOR_SMSC,
> -      .idProduct = USB_PRODUCT_USB5534B,
> -      .bInterfaceClass = USB_CLASS_HUB,
> -      .driver_info = HUB_QUIRK_DISABLE_AUTOSUSPEND},
> -    { .match_flags = USB_DEVICE_ID_MATCH_VENDOR
> -                   | USB_DEVICE_ID_MATCH_PRODUCT,
> -      .idVendor = USB_VENDOR_CYPRESS,
> -      .idProduct = USB_PRODUCT_CY7C65632,
> -      .driver_info = HUB_QUIRK_DISABLE_AUTOSUSPEND},
> -    { .match_flags = USB_DEVICE_ID_MATCH_VENDOR
> +	{ .match_flags = USB_DEVICE_ID_MATCH_VENDOR
> +			| USB_DEVICE_ID_MATCH_PRODUCT
> +			| USB_DEVICE_ID_MATCH_INT_CLASS,
> +	  .idVendor = USB_VENDOR_SMSC,

Spaces after the tab. Are you sure this does not cause checkpatch
--strict errors?



Best regards,
Krzysztof




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux