Re: [PATCH v6 0/2] usb: serial: add support for CH348

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Tested-by: David Heidelberg <david@xxxxxxx>
Reviewed-by: David Heidelberg <david@xxxxxxx>

Thank you

On 28/06/2023 15:38, Corentin Labbe wrote:
Hello

The CH348 is an octo serial to USB adapter.
The following patch adds a driver for supporting it.
Since there is no public datasheet, unfortunatly it remains some magic values.

It was tested with a large range of baud from 1200 to 1500000 and used with
success in one of our kernel CI testlab.

Regards

Changes since v1:
- use a data structure for encoding/decoding messages.
- check if needed endpoints exists
- fix URB leak in ch348_allocate_status_read error case
- test for maximum baud rate as stated by datasheet

Changes since v2:
- specify ch348_rxbuf data length
- Use correct speed_t dwDTERate instead of __le32
- test for maximum baud rate supported according to datasheet
- Use a define for CH348_TX_HDRSIZE

Changes since v3
- Fixed all reported problem from https://lore.kernel.org/lkml/Y5NDwEakGJbmB6+b@Red/T/#mb6234d0427cfdabf412190565e215995a41482dd
   Mostly reworked the endpoint mux to be the same than mx_uport

Changes since v4:
- The V4 was sent against stable and next have ch348_set_termios ktermios
   parameter const that I forgot to change

Changes since v5:
- Fixed all reported problem from https://lore.kernel.org/lkml/20230106135338.643951-1-clabbe@xxxxxxxxxxxx/T/#m044aab24dfb652ea34aa06f8ef704da9d6a2e036
- Major change is dropping of all status handling which was unused.
   It will be probably necessary to bring it back when using GPIO.
   This will be done when I will finish my next devboard.

Corentin Labbe (2):
   usb: serial: add support for CH348
   usb: serial: add myself as maintainer of CH348

  MAINTAINERS                 |   5 +
  drivers/usb/serial/Kconfig  |   9 +
  drivers/usb/serial/Makefile |   1 +
  drivers/usb/serial/ch348.c  | 491 ++++++++++++++++++++++++++++++++++++
  4 files changed, 506 insertions(+)
  create mode 100644 drivers/usb/serial/ch348.c

--
David Heidelberg
Consultant Software Engineer




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux