Hi Krzysztof,
> On 27/06/2023 10:20, Stanley Chang wrote:
> > Add the documentation explain the property about Realtek USB PHY driver.
> >
> > Realtek DHC (digital home center) RTD SoCs support DWC3 XHCI USB
> > controller. Added the driver to drive the USB 2.0 PHY transceivers.
> >
> > Signed-off-by: Stanley Chang <stanley_chang@xxxxxxxxxxx>
> > ---
> > v4 to v5 change:
> > 1. Add more examples.
>
> Not more examples. Just give one or two relevant examples.
Okay. I will keep just one example.
>
>
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - "#phy-cells"
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + usb_port0_usb2phy: usb-phy@13214 {
>
> Drop also the labels.
Okay
> > + compatible = "realtek,rtd1319d-usb2phy";
> > + reg = <0x13214 0x4>, <0x28280 0x4>;
> > + #phy-cells = <0>;
> > + nvmem-cells = <&otp_usb_port0_dc_cal>,
> <&otp_usb_port0_dc_dis>;
> > + nvmem-cell-names = "usb-dc-cal", "usb-dc-dis";
> > +
> > + realtek,driving-level = <0xe>;
>
> Why keeping this example? I asked to grow it and instead there are two more.
> Just keep one describing as much as possible. Second is useful if you have there
> different properties.
>
> Your third is almost the same as second, so no need for it at all.
They are real examples for different platform.
So I don't add other properties to example 1.
I will remove example 1 and example 3.
Thanks,
Stanley
