RE: [PATCH v4 5/5] dt-bindings: phy: realtek: Add the doc about the Realtek SoC USB 3.0 PHY

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Krzysztof,

> > +properties:
> > +  compatible:
> > +    items:
> > +      - enum:
> > +          - realtek,rtd1295-usb3phy
> > +          - realtek,rtd1319-usb3phy
> > +          - realtek,rtd1319d-usb3phy
> > +          - realtek,rtd1619-usb3phy
> > +          - realtek,rtd1619b-usb3phy
> > +      - const: realtek,usb3phy
> 
> Drop last compatible, it is not used now. Does not make sense.

Okay. I will remove it.

> > +
> > +  reg:
> > +    description: PHY data registers
> 
> Drop description, it's obvious.

Okay.

> > +    maxItems: 1
> > +
> > +  "#phy-cells":
> > +    const: 0
> > +
> > +  nvmem-cells:
> > +    maxItems: 1
> > +    description: A phandle to the tx lfps swing trim data provided by
> > +      a nvmem device, if unspecified, default values shall be used.
> > +
> > +  nvmem-cell-names:
> > +    items:
> > +      - const: usb_u3_tx_lfps_swing_trim
> > +
> > +  realtek,amplitude-control-coarse-tuning:
> > +    description:
> > +      This adjusts the signal amplitude for normal operation and beacon
> LFPS.
> > +      This value is a parameter for coarse tuning.
> > +      For different boards, if the default value is inappropriate, this
> > +      property can be assigned to adjust.
> 
> default:

I will add it.

> > +    $ref: /schemas/types.yaml#/definitions/uint32
> > +    minimum: 0
> > +    maximum: 255
> > +
> > +  realtek,amplitude-control-fine-tuning:
> > +    description:
> > +      This adjusts the signal amplitude for normal operation and beacon
> LFPS.
> > +      This value is used for fine-tuning parameters.
> > +    $ref: /schemas/types.yaml#/definitions/uint32
> 
> default:

I will add it.

> > +    minimum: 0
> > +    maximum: 65535
> > +
> 

Thanks,
Stanley




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux