On Thu, Jun 15, 2023 at 5:33 AM Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > On Wed, Jun 14, 2023 at 02:10:26PM +0000, Azeem Shaikh wrote: > > strlcpy() reads the entire source buffer first. > > This read may exceed the destination size limit. > > This is both inefficient and can lead to linear read > > overflows if a source string is not NUL-terminated [1]. > > In an effort to remove strlcpy() completely [2], replace > > strlcpy() here with strscpy(). > > > > Direct replacement is safe here since return value of -errno > > is used to check for truncation instead of sizeof(dest). > > > > [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy > > [2] https://github.com/KSPP/linux/issues/89 > > > > Signed-off-by: Azeem Shaikh <azeemshaikh38@xxxxxxxxx> > > --- > > v1: https://lore.kernel.org/all/20230613004402.3540432-1-azeemshaikh38@xxxxxxxxx/ > > > > Changes from v1 - uses "< 0" instead of "== -E2BIG". > > Please fix the reported errors from the build bot. > Sorry about that, I was hasty with sending out v2. Sent out a build tested v3.
