Hi Krzysztof,
> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Sent: Wednesday, June 14, 2023 3:18 AM
> To: Xu Yang <xu.yang_2@xxxxxxx>; robh+dt@xxxxxxxxxx; krzysztof.kozlowski+dt@xxxxxxxxxx; conor+dt@xxxxxxxxxx
> Cc: shawnguo@xxxxxxxxxx; s.hauer@xxxxxxxxxxxxxx; kernel@xxxxxxxxxxxxxx; festevam@xxxxxxxxx; dl-linux-imx <linux-
> imx@xxxxxxx>; linux-phy@xxxxxxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-
> usb@xxxxxxxxxxxxxxx; Jun Li <jun.li@xxxxxxx>
> Subject: [EXT] Re: [PATCH v2 2/2] dt-bindings: phy: mxs-usb-phy: add imx8ulp and imx8qm compatible
>
> Caution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the
> message using the 'Report this email' button
>
>
> On 08/06/2023 05:36, Xu Yang wrote:
> > The imx8ulp and imx8qm are compatible with imx8dxl. This will add such
> > compatible.
> >
> > Signed-off-by: Xu Yang <xu.yang_2@xxxxxxx>
> >
> > ---
> > Changes in v2:
> > - no change
> > ---
> > Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml
> b/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml
> > index 1b6b19fdf491..1395a982c387 100644
> > --- a/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml
> > +++ b/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml
> > @@ -32,7 +32,10 @@ properties:
> > - const: fsl,imx7ulp-usbphy
> > - const: fsl,imx6ul-usbphy
> > - items:
> > - - const: fsl,imx8dxl-usbphy
> > + - enum:
> > + - fsl,imx8ulp-usbphy
> > + - fsl,imx8dxl-usbphy
> > + - fsl,imx8qm-usbphy
>
> Keep the items sorted. Your previous patch also had wrongly ordered
> imx6ul in enum.
V4 already fix this issue as below:
@@ -29,7 +29,10 @@ properties:
- const: fsl,imx6ul-usbphy
- const: fsl,imx23-usbphy
- items:
- - const: fsl,imx8dxl-usbphy
+ - enum:
+ - fsl,imx8dxl-usbphy
+ - fsl,imx8qm-usbphy
+ - fsl,imx8ulp-usbphy
- const: fsl,imx7ulp-usbphy
Thanks,
Xu Yang
>
> Best regards,
> Krzysztof
