On 08/06/2023 08:59, Stanley Chang[昌育德] wrote: > Hi Krzysztof, > > >> I commented on your second patch, but everything is applicable here as well. >> You have many useless debug messages. Many incorrect or useless >> "if() return" which point to broken driver design (e.g. concurrent access to half >> initialized structures where you substitute lack of synchronization with >> incorrect "if() return"). Undocumented user interface is one more big trouble. >> >> I doubt you run checkpatch on this (be sure to run it with --strict and fix almost >> everything). >> >> > 1. I use checkpatch but without --strict. I will add it add and check again. > 2. Do the debugfs interfaces need to provide a document? > I don't find any reference about this. debugfs interface is for debug but in your case you don't use it that way. Best regards, Krzysztof
