On Sun, Jun 4, 2023 at 12:55 AM Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> wrote: > > Hi Greg, > > On Sun, Jun 04, 2023 at 09:43:40AM +0200, Greg KH wrote: > > On Fri, Jun 02, 2023 at 03:04:55PM -0700, Avichal Rakesh wrote: > > > This patch elaborates on some of the edge cases handled by > > > video_pump around setting no_interrupt flag, and brings the > > > code style in line with rest of the file. > > > > When you say "and" that usually means it should be a separate patch. > > > > But I really don't see what coding style changes you made here, what was > > it? > > > > I can't see any logical changes made here, am I missing them? Or is > > this all just a style-cleanup patch? > > It's all style cleanup (variable declaration ordering), typo fixes, and > naming and documentation improvement, yes. I reviewed Avichal's original > patch when coming back from holidays, neither of us realizing that you > had merged it already. He sent a v2 and got told to rebase it on top of > your tree. That's what v3 is, just handling the review comments. > > I generally ask for patches to be split with one change per patch, but > given the small changes bundled here, and the fact that all of this just > incorporates the review comments, I think it would be a bit overkill. > Apologies for the goof up. I hadn't realized that Linus' master wasn't the very tip of the Linux tree, and assumed the v1 merge had fallen behind. I am happy to split it up into smaller patches if you want, but as Laurent already mentioned: this is just documentation and styling cleanup from V1 with no logic fixes. - Avi.
