On Fri, Jun 2, 2023 at 12:11 PM Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx> wrote: > > When USB4 port is in offline mode (this mean there is no device > attached) we want to keep the sideband up to make it possible to > communicate with the retimers. In the same way there is no need to > enable sideband transactions when the USB4 port is not offline as they > are already up. > > For this reason make the enabling/disabling depend on the USB4 port > offline status. I'm probably missing something here, but if we don't allow disabling it when the port is offline, and when the port is online the sideband is enabled, when can it be disabled? If we can manually disable it when the port is online, on enablement we can't assume that it's already enabled just because the port is online, as we might have manually disabled it earlier.
