Re: [PATCH] usb: misc: onboard_hub: Don't warn twice about problems during remove

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, May 30, 2023 at 09:36:33AM +0200, Uwe Kleine-König wrote:
> If onboard_hub_power_off() called by onboard_hub_remove() fails it emits
> an error message. Forwarding the returned error value to the driver core
> results in another error message. As the return value is otherwise
> ignored, just drop the return value. There is no side effect apart from
> suppressing the core's warning.
> 
> Instead of returning zero unconditionally, convert to .remove_new()
> which has the same semantics as .remove() that unconditionally returns
> zero.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>

Acked-by: Matthias Kaehlcke <mka@xxxxxxxxxxxx>



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux