RE: [PATCH v2 1/3] usb: phy: add usb phy notify port status API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Greg,

> > Why can't this be part of the same notify_connect() callback?
> >
> > The notify connect is at device ready. But I want notify port status change
> before port reset.
> >
> > > What makes it different somehow?  Please document this much better.
> >
> > In Realtek phy driver, we have designed to dynamically adjust disconnection
> level and calibrate phy parameters.
> > So we do this when the device connected bit changes and when the
> disconnected bit changes.
> > Port status change notification:
> > 1. Check if portstatus is USB_PORT_STAT_CONNECTION and portchange is
> USB_PORT_STAT_C_CONNECTION.
> >   The device is connected, the driver lowers the disconnection level and
> calibrates the phy parameters.
> > 2. The device disconnects, the driver increases the disconnect level and
> calibrates the phy parameters.
> >
> > If we adjust the disconnection level in notify_connect , the disconnect may
> have been triggered at this stage.
> > So we need to change that as early as possible.
> 
> Please put this type of information in the changelog and in the comments for
> the callback when you resubmit it.

Okay, I will add this information at next version.

Thanks,
Stanley




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux