On 5/18/23 03:01, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart from
> emitting a warning) and this typically results in resource leaks. To improve
> here there is a quest to make the remove callback return void. In the first
> step of this quest all drivers are converted to .remove_new() which already
> returns void. Eventually after all drivers are converted, .remove_new() is
> renamed to .remove().
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
Acked-by: Minas Harutyunyan <Minas.Harutyunyan@xxxxxxxxxxxx>
> ---
> drivers/usb/dwc2/platform.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/usb/dwc2/platform.c b/drivers/usb/dwc2/platform.c
> index 5aee284018c0..3157db9f21bd 100644
> --- a/drivers/usb/dwc2/platform.c
> +++ b/drivers/usb/dwc2/platform.c
> @@ -288,7 +288,7 @@ static int dwc2_lowlevel_hw_init(struct dwc2_hsotg *hsotg)
> * stops device processing. Any resources used on behalf of this device are
> * freed.
> */
> -static int dwc2_driver_remove(struct platform_device *dev)
> +static void dwc2_driver_remove(struct platform_device *dev)
> {
> struct dwc2_hsotg *hsotg = platform_get_drvdata(dev);
> struct dwc2_gregs_backup *gr;
> @@ -341,8 +341,6 @@ static int dwc2_driver_remove(struct platform_device *dev)
>
> reset_control_assert(hsotg->reset);
> reset_control_assert(hsotg->reset_ecc);
> -
> - return 0;
> }
>
> /**
> @@ -746,7 +744,7 @@ static struct platform_driver dwc2_platform_driver = {
> .pm = &dwc2_dev_pm_ops,
> },
> .probe = dwc2_driver_probe,
> - .remove = dwc2_driver_remove,
> + .remove_new = dwc2_driver_remove,
> .shutdown = dwc2_driver_shutdown,
> };
>
