On Thu, May 25, 2023 at 4:12 PM Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
>
> We need to do some clean up before returning on this error path.
>
> Fixes: 0d45a1373e66 ("usb: phy: tahvo: add IRQ check")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Hi Dan,
it seems this patch is already submitted with Yang Li from our mailing
list. Please refer to:
https://www.spinics.net/lists/linux-usb/msg240531.html
> ---
> drivers/usb/phy/phy-tahvo.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/phy/phy-tahvo.c b/drivers/usb/phy/phy-tahvo.c
> index 47562d49dfc1..5cac31c6029b 100644
> --- a/drivers/usb/phy/phy-tahvo.c
> +++ b/drivers/usb/phy/phy-tahvo.c
> @@ -391,7 +391,7 @@ static int tahvo_usb_probe(struct platform_device *pdev)
>
> tu->irq = ret = platform_get_irq(pdev, 0);
> if (ret < 0)
> - return ret;
> + goto err_remove_phy;
> ret = request_threaded_irq(tu->irq, NULL, tahvo_usb_vbus_interrupt,
> IRQF_ONESHOT,
> "tahvo-vbus", tu);
> --
> 2.39.2
>
