On Thu, May 18, 2023, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart from
> emitting a warning) and this typically results in resource leaks. To improve
> here there is a quest to make the remove callback return void. In the first
> step of this quest all drivers are converted to .remove_new() which already
> returns void. Eventually after all drivers are converted, .remove_new() is
> renamed to .remove().
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> ---
> drivers/usb/dwc3/dwc3-imx8mp.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/usb/dwc3/dwc3-imx8mp.c b/drivers/usb/dwc3/dwc3-imx8mp.c
> index 174f07614318..8b9a3bb587bf 100644
> --- a/drivers/usb/dwc3/dwc3-imx8mp.c
> +++ b/drivers/usb/dwc3/dwc3-imx8mp.c
> @@ -266,7 +266,7 @@ static int dwc3_imx8mp_probe(struct platform_device *pdev)
> return err;
> }
>
> -static int dwc3_imx8mp_remove(struct platform_device *pdev)
> +static void dwc3_imx8mp_remove(struct platform_device *pdev)
> {
> struct dwc3_imx8mp *dwc3_imx = platform_get_drvdata(pdev);
> struct device *dev = &pdev->dev;
> @@ -280,8 +280,6 @@ static int dwc3_imx8mp_remove(struct platform_device *pdev)
> pm_runtime_disable(dev);
> pm_runtime_put_noidle(dev);
> platform_set_drvdata(pdev, NULL);
> -
> - return 0;
> }
>
> static int __maybe_unused dwc3_imx8mp_suspend(struct dwc3_imx8mp *dwc3_imx,
> @@ -411,7 +409,7 @@ MODULE_DEVICE_TABLE(of, dwc3_imx8mp_of_match);
>
> static struct platform_driver dwc3_imx8mp_driver = {
> .probe = dwc3_imx8mp_probe,
> - .remove = dwc3_imx8mp_remove,
> + .remove_new = dwc3_imx8mp_remove,
> .driver = {
> .name = "imx8mp-dwc3",
> .pm = &dwc3_imx8mp_dev_pm_ops,
> --
> 2.39.2
>
Acked-by: Thinh Nguyen <Thinh.Nguyen@xxxxxxxxxxxx>
Thanks,
Thinh
