Re: [PATCH 96/97] usb: typec: ucsi: acpi: Convert to platform remove callback returning void

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, May 18, 2023 at 01:02:38AM +0200, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart from
> emitting a warning) and this typically results in resource leaks. To improve
> here there is a quest to make the remove callback return void. In the first
> step of this quest all drivers are converted to .remove_new() which already
> returns void. Eventually after all drivers are converted, .remove_new() is
> renamed to .remove().
> 
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>

Acked-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>

> ---
>  drivers/usb/typec/ucsi/ucsi_acpi.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/usb/typec/ucsi/ucsi_acpi.c b/drivers/usb/typec/ucsi/ucsi_acpi.c
> index 217355f1f9b9..6bbf490ac401 100644
> --- a/drivers/usb/typec/ucsi/ucsi_acpi.c
> +++ b/drivers/usb/typec/ucsi/ucsi_acpi.c
> @@ -212,7 +212,7 @@ static int ucsi_acpi_probe(struct platform_device *pdev)
>  	return 0;
>  }
>  
> -static int ucsi_acpi_remove(struct platform_device *pdev)
> +static void ucsi_acpi_remove(struct platform_device *pdev)
>  {
>  	struct ucsi_acpi *ua = platform_get_drvdata(pdev);
>  
> @@ -221,8 +221,6 @@ static int ucsi_acpi_remove(struct platform_device *pdev)
>  
>  	acpi_remove_notify_handler(ACPI_HANDLE(&pdev->dev), ACPI_DEVICE_NOTIFY,
>  				   ucsi_acpi_notify);
> -
> -	return 0;
>  }
>  
>  static int ucsi_acpi_resume(struct device *dev)
> @@ -247,7 +245,7 @@ static struct platform_driver ucsi_acpi_platform_driver = {
>  		.acpi_match_table = ACPI_PTR(ucsi_acpi_match),
>  	},
>  	.probe = ucsi_acpi_probe,
> -	.remove = ucsi_acpi_remove,
> +	.remove_new = ucsi_acpi_remove,
>  };
>  
>  module_platform_driver(ucsi_acpi_platform_driver);
> -- 
> 2.39.2

-- 
heikki



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux