On Wed, 10 May 2023, Hans de Goede wrote: > Not all triggers use LED_INIT_DEFAULT_TRIGGER, which means that it > will not get cleared when the default trigger is a trigger which > does not use it such as "default-on". > > If the default trigger then later gets replaced by a trigger which > does check LED_INIT_DEFAULT_TRIGGER, such as "timer" then that trigger > will behave as if it is the default trigger which it should not do. > > To fix this clear the LED_INIT_DEFAULT_TRIGGER flag when clearing > the current trigger, so that it will not be set for any subsequently > set (non default) triggers. > > Reviewed-by: Jacek Anaszewski <jacek.anaszewski@xxxxxxxxx> > Tested-by: Yauhen Kharuzhy <jekhor@xxxxxxxxx> > Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx> > --- > drivers/leds/led-triggers.c | 1 + > 1 file changed, 1 insertion(+) Applied, thanks -- Lee Jones [李琼斯]