On Thu, 18 May 2023 at 04:34, Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> wrote: > > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is ignored (apart from > emitting a warning) and this typically results in resource leaks. To improve > here there is a quest to make the remove callback return void. In the first > step of this quest all drivers are converted to .remove_new() which already > returns void. Eventually after all drivers are converted, .remove_new() is > renamed to .remove(). > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> > --- > drivers/usb/misc/qcom_eud.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/usb/misc/qcom_eud.c b/drivers/usb/misc/qcom_eud.c > index b7f13df00764..0dc414463759 100644 > --- a/drivers/usb/misc/qcom_eud.c > +++ b/drivers/usb/misc/qcom_eud.c > @@ -217,7 +217,7 @@ static int eud_probe(struct platform_device *pdev) > return 0; > } > > -static int eud_remove(struct platform_device *pdev) > +static void eud_remove(struct platform_device *pdev) > { > struct eud_chip *chip = platform_get_drvdata(pdev); > > @@ -226,8 +226,6 @@ static int eud_remove(struct platform_device *pdev) > > device_init_wakeup(&pdev->dev, false); > disable_irq_wake(chip->irq); > - > - return 0; > } > > static const struct of_device_id eud_dt_match[] = { > @@ -238,7 +236,7 @@ MODULE_DEVICE_TABLE(of, eud_dt_match); > > static struct platform_driver eud_driver = { > .probe = eud_probe, > - .remove = eud_remove, > + .remove_new = eud_remove, > .driver = { > .name = "qcom_eud", > .dev_groups = eud_groups, > -- > 2.39.2 Reviewed-by: Bhupesh Sharma <bhupesh.sharma@xxxxxxxxxx> Thanks.