Hi Uwe,
> From: Uwe Kleine-König, Sent: Thursday, May 18, 2023 8:02 AM
>
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart from
> emitting a warning) and this typically results in resource leaks. To improve
> here there is a quest to make the remove callback return void. In the first
> step of this quest all drivers are converted to .remove_new() which already
> returns void. Eventually after all drivers are converted, .remove_new() is
> renamed to .remove().
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
Thank you for the patch!
Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
Best regards,
Yoshihiro Shimoda
> ---
> drivers/usb/gadget/udc/m66592-udc.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/usb/gadget/udc/m66592-udc.c b/drivers/usb/gadget/udc/m66592-udc.c
> index 06e21cee431b..e05f45a4b56b 100644
> --- a/drivers/usb/gadget/udc/m66592-udc.c
> +++ b/drivers/usb/gadget/udc/m66592-udc.c
> @@ -1512,7 +1512,7 @@ static const struct usb_gadget_ops m66592_gadget_ops = {
> .pullup = m66592_pullup,
> };
>
> -static int m66592_remove(struct platform_device *pdev)
> +static void m66592_remove(struct platform_device *pdev)
> {
> struct m66592 *m66592 = platform_get_drvdata(pdev);
>
> @@ -1527,7 +1527,6 @@ static int m66592_remove(struct platform_device *pdev)
> clk_put(m66592->clk);
> }
> kfree(m66592);
> - return 0;
> }
>
> static void nop_completion(struct usb_ep *ep, struct usb_request *r)
> @@ -1688,7 +1687,7 @@ static int m66592_probe(struct platform_device *pdev)
>
> /*-------------------------------------------------------------------------*/
> static struct platform_driver m66592_driver = {
> - .remove = m66592_remove,
> + .remove_new = m66592_remove,
> .driver = {
> .name = udc_name,
> },
> --
> 2.39.2
