On 18.05.2023 02:01, Uwe Kleine-König wrote:
>
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart from
> emitting a warning) and this typically results in resource leaks. To improve
> here there is a quest to make the remove callback return void. In the first
> step of this quest all drivers are converted to .remove_new() which already
> returns void. Eventually after all drivers are converted, .remove_new() is
> renamed to .remove().
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
Reviewed-by: Claudiu Beznea <claudiu.beznea@xxxxxxxxxxxxx>
> ---
> drivers/usb/host/ehci-atmel.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/usb/host/ehci-atmel.c b/drivers/usb/host/ehci-atmel.c
> index 8b775e7bab06..61808c51e702 100644
> --- a/drivers/usb/host/ehci-atmel.c
> +++ b/drivers/usb/host/ehci-atmel.c
> @@ -173,7 +173,7 @@ static int ehci_atmel_drv_probe(struct platform_device *pdev)
> return retval;
> }
>
> -static int ehci_atmel_drv_remove(struct platform_device *pdev)
> +static void ehci_atmel_drv_remove(struct platform_device *pdev)
> {
> struct usb_hcd *hcd = platform_get_drvdata(pdev);
>
> @@ -181,8 +181,6 @@ static int ehci_atmel_drv_remove(struct platform_device *pdev)
> usb_put_hcd(hcd);
>
> atmel_stop_ehci(pdev);
> -
> - return 0;
> }
>
> static int __maybe_unused ehci_atmel_drv_suspend(struct device *dev)
> @@ -223,7 +221,7 @@ static SIMPLE_DEV_PM_OPS(ehci_atmel_pm_ops, ehci_atmel_drv_suspend,
>
> static struct platform_driver ehci_atmel_driver = {
> .probe = ehci_atmel_drv_probe,
> - .remove = ehci_atmel_drv_remove,
> + .remove_new = ehci_atmel_drv_remove,
> .shutdown = usb_hcd_platform_shutdown,
> .driver = {
> .name = "atmel-ehci",
> --
> 2.39.2
>
