On Wed, May 17, 2023, at 01:34, Fabio Estevam wrote: > On Tue, May 16, 2023 at 12:32 PM Arnd Bergmann <arnd@xxxxxxxxxx> wrote: >> >> From: Arnd Bergmann <arnd@xxxxxxxx> >> >> This function has no prototype and no callers: >> >> arm/mach-imx/cpu-imx25.c:43:5: error: no previous prototype for 'mx25_revision' [-Werror=missing-prototypes] >> >> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx> > > Martin Kaiser sent a patch adding a user for this function: > > https://lore.kernel.org/linux-arm-kernel/20220815190748.102664-2-martin@xxxxxxxxx/ > > It would be better to apply Martin's patch instead of removing mx25_revision(). I think either way is ok to address the warning. If we wanted to do this properly, the mx{25,27,31,35,5}_revision functions could all be removed and the logic hooked up to imx_set_soc_revision() in the same way that they already use mxc_set_cpu_type() for drivers/soc/imx/soc-imx.c. I'll leave it up to you, if you want to merge Martin's patches or a replacement for the soc-imx driver through the imx tree for 6.5, I'll drop my patch from this series, otherwise I'll keep it for now and we can still do it better at later point. Arnd
