On 11/05/2023 17:49, Krzysztof Kozlowski wrote: > On 11/05/2023 14:16, Roger Quadros wrote: >> >> >> On 11/05/2023 12:26, Krzysztof Kozlowski wrote: >>> On 10/05/2023 15:28, Minda Chen wrote: >>>> To support generic clock and reset init in Cadence USBSS >>>> controller, add clock and reset dts configuration. >>>> >>>> Signed-off-by: Minda Chen <minda.chen@xxxxxxxxxxxxxxxx> >>>> --- >>>> .../devicetree/bindings/usb/cdns,usb3.yaml | 14 ++++++++++++++ >>>> 1 file changed, 14 insertions(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/usb/cdns,usb3.yaml b/Documentation/devicetree/bindings/usb/cdns,usb3.yaml >>>> index cae46c4982ad..623c6b34dee3 100644 >>>> --- a/Documentation/devicetree/bindings/usb/cdns,usb3.yaml >>>> +++ b/Documentation/devicetree/bindings/usb/cdns,usb3.yaml >>>> @@ -42,6 +42,18 @@ properties: >>>> - const: otg >>>> - const: wakeup >>>> >>>> + clocks: >>>> + minItems: 1 >>>> + maxItems: 8 >>>> + description: >>>> + USB controller clocks. >>> >>> You need to list the items. And why is it variable? Your clock choice in >>> the example is poor, I doubt it is real. >>> >>>> + >>>> + resets: >>>> + minItems: 1 >>>> + maxItems: 8 >>>> + description: >>>> + USB controller generic resets. >>> >>> Here as well. >>> >>> You had one clock last time, thus the review was - drop the names. Now >>> you changed it to 8 clocks... I don't understand. >>> >> >> Different platforms may have different number of clocks/resets or none. >> So I don't think minItems/maxItems should be specified. > > Yeah, but we want the clocks to be specific per platform. Not anything > anywhere. > Agreed. So we don't specify min/maxItems at top level but use conditional constraints per platform? Which means we will need to add platform specific compatibles as well. -- cheers, -roger
