Re: [PATCH] usb: xhci: Remove unused udev from xhci_log_ctx trace event

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 3/23/23 7:45 PM, Mathias Nyman wrote:
On 23.3.2023 15.13, Udipto Goswami wrote:
xhci_log_ctx event is not utilizing the extracted udev to
print out anything, hence removing it.

Fixes: 1d27fabec068 ("xhci: add xhci_address_ctx trace event")
Signed-off-by: Udipto Goswami <quic_ugoswami@xxxxxxxxxxx>
---
  drivers/usb/host/xhci-trace.h | 4 ----
  1 file changed, 4 deletions(-)

diff --git a/drivers/usb/host/xhci-trace.h b/drivers/usb/host/xhci-trace.h
index 4286dba5b157..7555c4ea7c4b 100644
--- a/drivers/usb/host/xhci-trace.h
+++ b/drivers/usb/host/xhci-trace.h
@@ -80,20 +80,16 @@ DECLARE_EVENT_CLASS(xhci_log_ctx,
          __field(dma_addr_t, ctx_dma)
          __field(u8 *, ctx_va)
          __field(unsigned, ctx_ep_num)
-        __field(int, slot_id)
          __dynamic_array(u32, ctx_data,
              ((HCC_64BYTE_CONTEXT(xhci->hcc_params) + 1) * 8) *
              ((ctx->type == XHCI_CTX_TYPE_INPUT) + ep_num + 1))
      ),
      TP_fast_assign(
-        struct usb_device *udev;
-        udev = to_usb_device(xhci_to_hcd(xhci)->self.controller);

Looks like this was flawed from the beginning, forcing a device struct for a host controller into
a struct usb_device

Hi Mathias, Greg,

Seems like this patch isn't included in upstream.
Please let me know what need to be done ? If a v2 is needed to push?

Thanks,
-Udipto





[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux