On Tue, May 09, 2023 at 10:17:31AM +0800, Hongren Zheng wrote: > On Mon, May 08, 2023 at 05:21:20PM -0400, Galen Guyer wrote: > > Suggest loading vhdi_hcd if it's not loaded to make error message less opaque > > > > Signed-off-by: Galen Guyer <galen@xxxxxxxxxxxxxx> > > Reviewed-By: Hongren Zheng <i@xxxxxxxxxxx> > > When I was young I usually get confused with this error message. > > BTW would you like to make other patches regarding the error generated > when kernel module not loaded? For example, when usbip-host is not > loaded, the error message of usbip bind does not give much help. > > $ usbip bind -b 1-6 > usbip: error: unable to bind device on 1-6 > > Another example is that when there is no gadget attached to > the usbip-vudc, the following error messages are not helpful > > $ usbipd -e -D > libusbip: error: Cannot read vudc device descr file: No such device > > $ usbip list -d > usbip: error: problem getting device attributes: No such device > > > > --- > > tools/usb/usbip/src/usbip_attach.c | 2 +- > > tools/usb/usbip/src/usbip_detach.c | 2 +- > > tools/usb/usbip/src/usbip_port.c | 2 +- > > 3 files changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/tools/usb/usbip/src/usbip_attach.c b/tools/usb/usbip/src/usbip_attach.c > > index b4aeb9f1f493..531a415538f9 100644 > > --- a/tools/usb/usbip/src/usbip_attach.c > > +++ b/tools/usb/usbip/src/usbip_attach.c > > @@ -86,7 +86,7 @@ static int import_device(int sockfd, struct usbip_usb_device *udev) > > > > rc = usbip_vhci_driver_open(); > > if (rc < 0) { > > - err("open vhci_driver"); > > + err("open vhci_driver (is vhci_hcd loaded?)"); One more thing: the kernel module is called vhci-hcd.ko instead of vhci_hcd. Though dmesg often shows vhci_hcd and this name is used in the code. > > goto err_out; > > } > > > > diff --git a/tools/usb/usbip/src/usbip_detach.c b/tools/usb/usbip/src/usbip_detach.c > > index aec993159036..b29101986b5a 100644 > > --- a/tools/usb/usbip/src/usbip_detach.c > > +++ b/tools/usb/usbip/src/usbip_detach.c > > @@ -50,7 +50,7 @@ static int detach_port(char *port) > > > > ret = usbip_vhci_driver_open(); > > if (ret < 0) { > > - err("open vhci_driver"); > > + err("open vhci_driver (is vhci_hcd loaded?)"); > > return -1; > > } > > > > diff --git a/tools/usb/usbip/src/usbip_port.c b/tools/usb/usbip/src/usbip_port.c > > index 4d14387df13d..21a20e378419 100644 > > --- a/tools/usb/usbip/src/usbip_port.c > > +++ b/tools/usb/usbip/src/usbip_port.c > > @@ -18,7 +18,7 @@ static int list_imported_devices(void) > > > > ret = usbip_vhci_driver_open(); > > if (ret < 0) { > > - err("open vhci_driver"); > > + err("open vhci_driver (is vhci_hcd loaded?)"); > > goto err_names_free; > > } > > > > -- > > 2.40.1 > >