On 05/05/2023 18:27, Bhupesh Sharma wrote: > Hi Krzysztof, > > On Fri, 5 May 2023 at 21:54, Krzysztof Kozlowski > <krzysztof.kozlowski@xxxxxxxxxx> wrote: >> >> On 05/05/2023 08:40, Bhupesh Sharma wrote: >>> Add dt-bindings for EUD found on Qualcomm SM6115 / SM4250 SoC. >>> >>> On this SoC (and derivatives) the enable bit inside 'tcsr_check_reg' >>> needs to be set first to 'enable' the eud module. >>> >>> So, update the dt-bindings to accommodate the third register >>> property (TCSR Base) required by the driver on these SoCs. >>> >>> Also for these SoCs, introduce a new bool property >>> 'qcom,secure-mode-enable', which indicates that the mode manager >>> needs to be accessed only via the secure world. >> >> Cannot it be implied by compatible? > > I can see this will be used by future SoCs as well from the available > EUD documentation. > > So let's keep a dedicated dt property as suggested by Bjorn in earlier > reviews, as otherwise the compatible checks would start getting bigger > / messier in the driver code, in my opinion, when we add EUD support > for other SoCs + boards. I don't understand the last part about compatible checks would grow. Why would you have any compatible check in the driver? This looks standard as we do with all SoC properties, so via driver data. Best regards, Krzysztof
