On 01/05/2023 14:11, Bryan O'Donoghue wrote: > Add a description for the Type-C silicon interface inside Qualcomm's > PM8150b hardware block. > > Based on original work by Wesley. > > Signed-off-by: Wesley Cheng <wcheng@xxxxxxxxxxxxxx> > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx> > --- Thank you for your patch. There is something to discuss/improve. Two nits below > + port@1 { > + reg = <1>; > + pmic_typec_role_switch_out: endpoint { > + remote-endpoint = <&usb_controller_role_switch_in>; > + }; > + }; > + }; > + }; > + }; > + }; > + > + usb_controller { No underscores in node names, just "usb" > + dr_mode = "otg"; > + usb-role-switch; > + port { > + usb_controller_role_switch_in: endpoint { > + remote-endpoint = <&pmic_typec_role_switch_out>; > + }; > + }; > + }; > + > + usb_phy { usb-phy With fixes above: Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> Best regards, Krzysztof